rust-lang / rust-analyzer

A Rust compiler front-end for IDEs
https://rust-analyzer.github.io/
Apache License 2.0
14.26k stars 1.61k forks source link

feat: Implement diagnostics for E0038 #18000

Open ShoyuVanilla opened 2 months ago

ShoyuVanilla commented 2 months ago

As #17814 was merged, I think that E0038 can be implemented with ease

ChayimFriedman2 commented 2 months ago

@rustbot claim

ChayimFriedman2 commented 2 months ago

This turned out not-so-easy since we currently have no infra for diagnostics in ty lowering...

ShoyuVanilla commented 2 months ago

This turned out not-so-easy since we currently have no infra for diagnostics in ty lowering...

Oops, you're right. I just remembered we have no such thing yet 😢

ChayimFriedman2 commented 2 months ago

@ShoyuVanilla I'm working on it, but it's a major change because of how ty lowering works.

ChayimFriedman2 commented 1 month ago

First step (almost) complete: https://github.com/rust-lang/rust-analyzer/pull/18074.