search

rust-lang / rust-analyzer

A Rust compiler front-end for IDEs
https://rust-analyzer.github.io/
Apache License 2.0
14.32k stars 1.61k forks source link

Replace Design label with C-Architecture #18492

Closed samestep closed 1 week ago

samestep commented 2 weeks ago

7445 added an item to docs/dev/README.md describing and linking to the "Design" issue label, which I assume existed at the time. Later, #12722 updated that URL to point to the new repo location. However, this bullet point is now confusing for two reasons:

  1. The URL https://github.com/rust-lang/rust-analyzer/issues?q=is%3Aopen+is%3Aissue+label%Design is malformed. Clicking it in Firefox produces a blank page. Interestingly, clicking the URL while editing this Markdown file inside VS Code changes it to the different URL https://github.com/rust-lang/rust-analyzer/issues?q=is:open+is:issue+label%25Design which is no longer malformed, but that just corresponds to the search string "is:open is:issue label%Design" which is not very meaningful.

  2. There are currently no issues labeled "Design". The corrected search URL https://github.com/rust-lang/rust-analyzer/issues?q=is:open+is:issue+label:Design causes GitHub to display this warning message:

    Filter contains 1 issue:

    • Invalid value Design for label

Therefore, this PR replaces that bullet point with a link to the C-Architecture tag.

lnicola commented 1 week ago

I think this is called C-Architecture these days.