rust-lang / rust-analyzer

A Rust compiler front-end for IDEs
https://rust-analyzer.github.io/
Apache License 2.0
14.31k stars 1.62k forks source link

Revert "Resolve completion items" #18501

Closed traviscross closed 1 week ago

traviscross commented 1 week ago

Reverting this commit fixes automatic importing in many editors.

Certainly there's probably a better way to fix this than a straight revert. But this does get things working again. Feel free, of course, to close this if a more targeted fix is available.

This fixes #18363.

This reverts commit 950bb83f818342d9f9ed472c1d30492db324f5a6.

cc @Veykril @SomeoneToIgnore

SomeoneToIgnore commented 1 week ago

Certainly there's probably a better way to fix this than a straight revert.

I would want to discuss that first: https://github.com/rust-lang/rust-analyzer/issues/18363#issuecomment-2467491145

to understand which properties are missing — then, at worst, we can always send back that particular subset always instead of the entire field list (as the revert will force us to do).