Generate additional function parameters from function call

[iLePix]

let's say we have the following code:

fn foo(x: i32) { ... }

I now want to add a second argument and add the parameter to the signature automatically, via assist.

foo(5, "bar");

resulting in this:

fn foo(x: i32, arg: &str) { ... }

This is somewhat similar to the assist to generate a new function based on a function call, but instead updating the signature of an existing function. This would be especially useful when using more complex types that can be inferred.

[SinanAkkoyun]

+1

[ChayimFriedman2]

Should this also update all other existing calls? If yes this runs into UI issues similar to those of the update signature helper, if not this isn't very useful.

[iLePix]

Should this also update all other existing calls? If yes this runs into UI issues similar to those of the update signature helper, if not this isn't very useful.

No it should only update the existing signature of the function. I disagree, since sometimes rust infers complex types that I must explicitly write out because there's no easy way to add them to already existing function arguments. I also think that creating erros at all call sites is rather a feature than a bug, since a change in the function signature has to be handled everywhere.