Type check error in sqlx chain

[neo-clon]

Hi guys

I have an error with the type checker when use sqlx crate and try use query and query_as methods

Envioment:

• NVIM v0.4.4
• coc.nvim version: 0.0.79-c7c24f61f4
• coc-rust-analyzer with rust-analyzer a0fa522
• rustup 1.23.1
• rustc 1.48.0

I see that when use query or query_as methods ( no proc macros ), rust analayzer can show inlay Hint correctly, but if i try use the bind method, not appear on intellisense options despite of the impl over the struct

And if i set the method, my lib works but inlay hints no work more on the chain

This bug happen both in neovim and vscode

[bmisiak]

Oh yeah, just hit this. vs

Also seeing some fun output:

[ERROR rust_analyzer] assertion failed at crates/completion/src/item.rs:401:13: multiline detail: pub fn query_as_with<'q, DB, O, A>(sql: &'q str, arguments: A) -> QueryAs<'q, DB, O, A>
where
    DB: Database,
    A: IntoArguments<'q, DB>,
    O: for<'r> FromRow<'r, DB::Row>,
[ERROR rust_analyzer] assertion failed at crates/completion/src/item.rs:401:13: multiline detail: pub fn query_with<'q, DB, A>(sql: &'q str, arguments: A) -> Query<'q, DB, A>
where
    DB: Database,
    A: IntoArguments<'q, DB>,
[ERROR rust_analyzer] assertion failed at crates/completion/src/item.rs:401:13: multiline detail: pub fn query_scalar_with<'q, DB, O, A>(sql: &'q str, arguments: A) -> QueryScalar<'q, DB, O, A>
where
    DB: Database,
    A: IntoArguments<'q, DB>,
    (O,): for<'r> FromRow<'r, DB::Row>,
[ERROR rust_analyzer] assertion failed at crates/completion/src/item.rs:401:13: multiline detail: pub fn query_as_with<'q, DB, O, A>(sql: &'q str, arguments: A) -> QueryAs<'q, DB, O, A>
where
    DB: Database,
    A: IntoArguments<'q, DB>,
    O: for<'r> FromRow<'r, DB::Row>,
[ERROR rust_analyzer] assertion failed at crates/completion/src/item.rs:401:13: multiline detail: pub fn query_with<'q, DB, A>(sql: &'q str, arguments: A) -> Query<'q, DB, A>
where
    DB: Database,
    A: IntoArguments<'q, DB>,
[ERROR rust_analyzer] assertion failed at crates/completion/src/item.rs:401:13: multiline detail: pub fn query_scalar_with<'q, DB, O, A>(sql: &'q str, arguments: A) -> QueryScalar<'q, DB, O, A>
where
    DB: Database,
    A: IntoArguments<'q, DB>,
    (O,): for<'r> FromRow<'r, DB::Row>,

[lnicola]

@bmisiak attribute proc macros are not supported.

[flodiebold]

@neo-clon @bmisiak can you provide a stand-alone, as small as possible reproduction?

[bmisiak]

Two repros:

The simplest one is this: https://github.com/bmisiak/repro-analyzer-sqlx/blob/master/src/main.rs It doesn't pass cargo check because sqlx needs a runtime, but it exhibits the inference problems just fine. If you need cargo check to work correctly, there is this slightly more complex branch with async-std: https://github.com/bmisiak/repro-analyzer-sqlx/blob/asyncstd/src/main.rs

Using sqlx::query_as (before getting to fetch_one) gives me the following hint: Only after adding .fetch_one can rust-analyzer properly infer all types: That is until I add a .bind:

[flodiebold]

Thanks! The bind method is defined in:

impl<'q, DB: Database, O> QueryAs<'q, DB, O, <DB as HasArguments<'q>>::Arguments>

The <DB as HasArguments<'q>>::Arguments is the problem; I haven't looked into it in detail yet, but I guess our code for checking that the self type matches the impl doesn't deal with this correctly. It might not be trivial to handle this without some refactorings.

[Dessix]

Is there a known workaround for this, since it's been around for a while?

[PorkSausages]

Also interested in a workaround if there is one as this issue is still present

[sanjeevprasad]

Also interested in a workaround if there is one as this issue is still present

yes there is an ugly and stupid workaround that I am using.

let mut q = sqlx::query_as::<_, User>(&GET_USER_BY_ID);
q = q.bind(&id); // rust-analyzer still don't have any idea
let user = q.fetch_one(p).await.unwrap(); // but it is working here