search

rust-lang / rust-bindgen

Automatically generates Rust FFI bindings to C (and some C++) libraries.
https://rust-lang.github.io/rust-bindgen/
BSD 3-Clause "New" or "Revised" License
4.23k stars 679 forks source link

ci: Try to fix macOS runner #2819

Closed emilio closed 2 months ago

emilio commented 2 months ago

Now seems to run on arm64 out of the blue...

pvdrz commented 2 months ago

It seems we're both trying to fix it: https://github.com/rust-lang/rust-bindgen/pull/2820 :rofl:

i believe this happens because llvm was built with a different xcode version or something. However, I think we're just being affected by this: https://github.com/actions/runner/issues/3256.

I also considered installing LLVM 9 on apple's arm but it seems the only prebuilt version can be installed via macports.

I think there's not much we can do regarding LLVM 9 on macos to be honest, specially if apple decides to drop x86 support eventually

emilio commented 2 months ago

I think there's not much we can do regarding LLVM 9 on macos to be honest, specially if apple decides to drop x86 support eventually

Yeah, that's why I approached this by trying to test in a new-ish llvm version... I think part of the issue is that somehow quote and co are using cc as a linker, rather than the LLVM we just downloaded...

emilio commented 2 months ago

But even with that fixed it fails so nvm...

leighmcculloch commented 2 months ago

Now seems to run on arm64 out of the blue...

According to this post by GitHub in January the macos-14 runner is exclusively arm64 and macos-latest was slated to update to 14 in April+:

This definitely landed in a way that was surprising though.

emilio commented 2 months ago

@pvdrz apparently macos-latest was macos-12, not macos-13, so downgrading to that fixes CI.