Tracking Issue: Prevent duplicate diagnostic emission of lints

[flip1995]

Description

Follow up to https://github.com/rust-lang/rust-clippy/pull/12374

That PR added the -Zdeduplicate-diagnostics=yes flag to the following test files, to suppress the warning that will now be produced should new lints/tests emit duplicated diagnostics. Old lints should still be cleaned up though. Those are the test files that were affected:

• [x] tests/ui/assign_ops2.rs
• [x] tests/ui/else_if_without_else.rs
• [x] tests/ui/identity_op.rs
• [ ] tests/ui/indexing_slicing_index.rs
  • Might be coming from the compiler: https://github.com/rust-lang/rust-clippy/issues/12379#issuecomment-2173305136
• [x] tests/ui/manual_retain.rs
• [x] tests/ui/many_single_char_names.rs
• [ ] tests/ui/min_rust_version_invalid_attr.rs
• [x] tests/ui/mut_mut.rs
• [x] tests/ui/no_effect_replace.rs
• [ ] tests/ui/nonminimal_bool_methods.rs
• [x] tests/ui/nonminimal_bool.rs
• [x] tests/ui/option_option.rs
• [x] tests/ui/ptr_as_ptr.rs
• [ ] tests/ui/renamed_builtin_attr.rs
• [x] tests/ui/single_match_else.rs
• [x] tests/ui/single_match.rs
• [x] tests/ui/std_instead_of_core.rs
• [ ] tests/ui/suspicious_operation_groupings.rs
• [x] tests/ui/type_complexity.rs
• [ ] tests/ui/unknown_attribute.rs

To fix some of those:

1. Pick one test and leave a comment about it
2. Remove the -Zdeduplicate-diagnostics=yes flag from it
3. Figure out the cause of duplicated diagnostic
4. Fix it and write a comment here so that it gets marked as resolved.

Version

No response

Additional Labels

No response

[UlazkaMateusz]

Hey, tests/ui/type_complexity.rs is fixed and merged

[flip1995]

Thanks, only 7 to go :rocket: I love how well this works, we have amazing contributors!

[grtn316]

It appears the duplicate diag messages for:tests/ui/indexing_slicing_index.rs may be coming from the compiler instead of this project.