[`non_canonical_partial_ord_impl`]: Fix emitting warnings which conflict with `needless_return`

rust-lang / rust-clippy

A bunch of lints to catch common mistakes and improve your Rust code. Book: https://doc.rust-lang.org/clippy/

https://rust-lang.github.io/rust-clippy/

Other

10.89k stars 1.45k forks source link

[`non_canonical_partial_ord_impl`]: Fix emitting warnings which conflict with `needless_return` #12702

Closed Luv-Ray closed 2 weeks ago

Luv-Ray commented 3 weeks ago

fixes #12683

changelog: fix [non_canonical_partial_ord_impl] emitting warnings which conflict with needless_return

rustbot commented 3 weeks ago

r? @Manishearth

rustbot has assigned @Manishearth. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Manishearth commented 2 weeks ago

@bors r+

thanks!!

bors commented 2 weeks ago

:pushpin: Commit 107e44b76ff76805bc9bea5dc2e4ba96354ab374 has been approved by Manishearth

It is now in the queue for this repository.

bors commented 2 weeks ago

:hourglass: Testing commit 107e44b76ff76805bc9bea5dc2e4ba96354ab374 with merge 9162bbf5acc8e0e914f07904167a3d1b6f0d2cbe...

bors commented 2 weeks ago

:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: Manishearth Pushing 9162bbf5acc8e0e914f07904167a3d1b6f0d2cbe to master...