Manual Duration::{as_nanos,as_milis,as_secs_f64,as_secs_f32} implementation

[est31]

What it does

Recognize cases of manual re-implementation of the builtin as_nanos and as_secs_f64 and as_secs_f32 functions on Duration.

Categories

• Kind: complexity, sometimes also correctness

Drawbacks

MSRV issues, implementing the suggestion might increase the MSRV.

Example

let nanos = diff.as_secs() * 1_000_000_000 + diff.subsec_nanos() as u64;
let milis = diff.as_secs() * 1_000 + diff.subsec_milis() as u64;
let secs_f64 = (diff.as_secs() as f64 * 1_000.0 + diff.subsec_milis() as f64) / 1000.0;
let secs_f64 = diff.as_secs() as f64 + diff.subsec_milis() as f64 / 1_000.0;
let secs_f64 = diff.as_secs() as f64 + diff.subsec_nanos() as f64 / 1_000_000_000.0;

Could be written as:

let nanos = diff.as_nanos() as u64;
let milis = diff.as_millis() as u64;
let secs_f64 = diff.as_secs_f64();
let secs_f64 = diff.as_secs_f64();
let secs_f64 = diff.as_secs_f64();

[est31]

Example encounters in the wild:

• https://github.com/rust-lang/cargo/pull/8721

• https://github.com/rust-lang/rust/pull/76958

[ghost]

I think duration_subsec should be renamed to manual_duration_calcs and extended to handle cases.

I think the minimum supported rust version is an issue an that needs to be handled globally for this project. I wouldn't worry about it while implementing this.

[himanoa]

Hi, Can I give it a try?

[llogiq]

It's all yours!