Incorrect collect suggestion - borrow doesn't live long enough

[sophiajt]

I tried this code:

    let string_clone: Vec<_> = concat_string.item.lines().map(|x| x.to_string()).collect();

    if objects {
        Ok(string_clone
            .into_iter()...

Clippy suggests turning this into:

Ok(concat_string.item.lines().map(|x| x.to_string())...

I expected to see this happen: clippy to suggest a correct replacement

Instead, this happened: clippy suggests the above, which will not compile as concat_string.item will not live long enough.

Meta

• cargo clippy -V: e.g. clippy 0.0.212 (f455e46 2020-06-20)
• rustc -Vv:

  C:\Source\nushell(main)> cargo clippy -V
  clippy 0.1.54 (ed597e7e 2021-06-08)
  C:\Source\nushell(main)> rustc -Vv
  rustc 1.54.0-nightly (ed597e7e1 2021-06-08)
  binary: rustc
  commit-hash: ed597e7e19d0fe716d9f81b1e840a5abbfd7c28d
  commit-date: 2021-06-08
  host: x86_64-pc-windows-msvc
  release: 1.54.0-nightly
  LLVM version: 12.0.1

Backtrace

``` ```

[sophiajt]

Another example of the same issue:

    let rows: Vec<Value> = ret_str
        .lines()
        .map(|v| v.to_str_value_create_tag())
        .collect();
    Ok((rows.into_iter().map(ReturnSuccess::value)).to_action_stream())