search

rust-lang / rust-forge

Information useful to people contributing to Rust
https://forge.rust-lang.org/
Apache License 2.0
465 stars 175 forks source link

Update all dependencies #708

Closed ehuss closed 1 year ago

ehuss commented 1 year ago

This updates all dependencies, including the version of mdbook used to build the site.

I dropped the use of clap since it was not really serving much purpose.

rustbot commented 1 year ago

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

apiraino commented 1 year ago

@ehuss as you point out here, clap cannot really yet be removed :slightly_smiling_face:

ehuss commented 1 year ago

Yea, I noted that in the commit message. Hopefully it can be fully removed in the future.

There are a few reasons for removing it in blacksmith. One is that updating mdbook updated from clap 3 to 4, so it would need to be updated in blacksmith, too. However, the API changed, and I didn't want to try to figure out how to rewrite the code. I do hope someday to get the mdbook preprocessor into a separate crate to drop the dependency. This may motivate me to actually work on that.