Do not use UPPER_CASE variables for script/function local variables

rust-lang / rust-installer

The Bourne shell installer used by Rust and Cargo

Apache License 2.0

61 stars 68 forks source link

Do not use UPPER_CASE variables for script/function local variables #1

Open postmodern opened 9 years ago

postmodern commented 9 years ago

In shell scripting UPPER_CASE environment variables are only intended to be passed between commands. To avoid outside environment variables from shadowing script/function local variables, use lower_case variable names instead.

Sources:

http://mywiki.wooledge.org/BashSheet#Parameters
http://wiki.bash-hackers.org/scripting/style#variable_names

brson commented 9 years ago

Thanks for the tip. My more recent scripts have stopped using allcaps everywhere and I'll go back through rust-installer and do some cleanup on this soon.