search

rust-lang / rust-installer

The Bourne shell installer used by Rust and Cargo
Apache License 2.0
61 stars 68 forks source link

Add manifest on Windows to avoid UAC popups #117

Open mati865 opened 1 year ago

mati865 commented 1 year ago

Since rename (https://github.com/rust-lang/rust-installer/pull/113) rust installer triggers Windows bug feature that makes 32-bit binaries with specific strings automatically trigger UAC prompt (https://learn.microsoft.com/en-us/previous-versions/aa905330(v=msdn.10)#installer-detection). This is an issue when running program in non-elevated shell like we do at MSYS2: https://github.com/msys2/MINGW-packages/issues/9091#issuecomment-1294257143, For that reason we carry this PR as downstream patch.

Here is how manifest is configured by the default with embed-manifest crate: https://docs.rs/embed-manifest/1.3.1/embed_manifest/fn.new_manifest.html

rust-highfive commented 1 year ago

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)