search

rust-lang / rust-installer

The Bourne shell installer used by Rust and Cargo
Apache License 2.0
60 stars 68 forks source link

Fix Cygwin support on Windows 10 #44

Closed cuviper closed 9 years ago

rust-highfive commented 9 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

cuviper commented 9 years ago

Test-wise, it used to fail right away on basic_install, and now it reports "TOTAL SUCCESS!"

brson commented 9 years ago

Thanks! To fully deploy the submodules in rust, cargo, rust-packaging, and multirust need to be updated. Feel free to do that, otherwise, I've made a note to do it myself.