search

rust-lang / rust-installer

The Bourne shell installer used by Rust and Cargo
Apache License 2.0
60 stars 68 forks source link

use invoking shell to execute other shell scripts #55

Closed binarycrusader closed 7 years ago

binarycrusader commented 7 years ago

Use the same shell that was used to invoke the script to execute other shell scripts.

This combined with pull request #81 completely fixes #25845

rust-highfive commented 7 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

alexcrichton commented 7 years ago

Ah in the meantime we've rewritten these scripts in Rust! I think in that case this may no longer apply (sorry for the delay!)