search

rust-lang / rust-log-analyzer

Analyzing Travis and Azure Pipelines logs to find encountered errors
MIT License
40 stars 27 forks source link

Messages of test fail from bors will be doubled. #1

Closed kennytm closed 6 years ago

kennytm commented 6 years ago

Example: https://github.com/rust-lang/rust/pull/49642#issuecomment-378645380

There are 2 identical comments.

cc @TimNN

TimNN commented 6 years ago

So the issue here is that

(1): Travis posts the status to the merge-commit, which we pick up (2): Bors posts the same status to the PR-commit, which we also pick up

I'll see if there is an easy way to ignore bors, if not I'll some kind of RLU cache and have the bot remember which builds it has already commented on (probably memory only, so that would be lost if the bot was ever restarted, but given that it's been running for without restart for ~3 months now, I don't think that is going to be an issue).

cc @RalfJung, since you recently asked about this issue.

kennytm commented 6 years ago

You should be able to distinguish between Travis and Bors by the context. The context used by Bors is currently homu, and those by Travis starts with continuous-integration/travis-ci/

TimNN commented 6 years ago

@kennytm: Thanks a lot! I hadn't even noticed that field, since it only occurs in the example and is not documented. (I was looking at sender just now, but that seems to be something else).