search

rust-lang / rust-log-analyzer

Analyzing Travis and Azure Pipelines logs to find encountered errors
MIT License
40 stars 27 forks source link

GitHub Actions support, part 1 #41

Closed pietroalbini closed 4 years ago

pietroalbini commented 4 years ago

This PR adds most of the code to support GitHub Actions in RLA, even though it doesn't fully work yet. I plan to open (multiple) followup PRs to fix the bugs uncovered during testing.

r? @Mark-Simulacrum cc https://github.com/rust-lang/rust/issues/70890

pietroalbini commented 4 years ago

I'm tracking GHA-related bugs with the github-actions label.

TimNN commented 4 years ago

I haven’t read the entire PR but just for context regarding the “initialize empty index file if not present”: With an untrained index, the results of RLA would be really bad. I think you’d end up attempting to post the entire log as a comment, which I assume GitHub would reject.

Mark-Simulacrum commented 4 years ago

Generally seems reasonable -- I don't know that I can review in fine detail (e.g. if the API calls make sense) without putting in a lot of time, and I suspect there's not much point beyond just running it and seeing if it works.

pietroalbini commented 4 years ago

I haven’t read the entire PR but just for context regarding the “initialize empty index file if not present”: With an untrained index, the results of RLA would be really bad. I think you’d end up attempting to post the entire log as a comment, which I assume GitHub would reject.

Great point, I added that during testing (since I didn't have a GHA index file yet). I'll remove the commit.

pietroalbini commented 4 years ago

Ok, merging this. I'll open followup PRs.