Closed mookid closed 4 years ago
r? @brotzeit
(rust_highfive has picked a reviewer for you, use r? to override)
I will take a look at it the next days.
@tarsius is working on a solution to making rustic modular https://github.com/brotzeit/rustic/pull/95. Maybe we can start another try to bring rust-mode and rustic together and reduce the maintenance burden.
FYI, using call-process-region
in rust--format-call
doesn't allow us to fix this kind of issue https://github.com/brotzeit/rustic/issues/19. But I guess that's not relevant for most users.
FYI, using
call-process-region
inrust--format-call
doesn't allow us to fix this kind of issue brotzeit/rustic#19. But I guess that's not relevant for most users.
Thanks for the pointer. A reference to the fixing commit would also be useful ;)
I removed the note about that because I thought you might don't like the solution =)
We would have to add some more logic around a call to make-process
. This would be a solution to the problem.
And when we add this it would be silly not to implement translation of ANSI control sequences through xterm-color(or whatever). So it would end up being more additional code and we decided to keep rust-mode a lightweight package.
FYI, using
call-process-region
inrust--format-call
doesn't allow us to fix this kind of issue brotzeit/rustic#19. But I guess that's not relevant for most users.
I can't reproduce that one. Let's keep an eye on it.
Re #314 I finally had some time to look at that one, I just fixed a typo on the way. Thanks for the patch, I love it!
cc @nikodemus
@brotzeit What do you think?