brotzeit
commented
2 years ago Sorry for the delay but I'm extremely careful changing regexes, especially when I don't totally understand the consequences. It was years ago that I have touched code that is related to compilation regexes. But I think I'll give this a try since I think I remember this issue(I'm using the code of my rust-mode extension that I wrote 4 years ago). If anybody notices problems please open an issue.
Currently the regex that matches panic messages in cargo output does not correctly match the file name and line number. This causes attempts to jump to one of these failures with
next-error(or similar commands) brings up a prompt for a file name to search in and generally causes unnecessary friction in dealing with test failures or other explicit panics during tests.This change to the regex provides at least a partial fix for that issue by reducing the amount of text matched so that it won't be a multi-line match. The new method has a small chance of false-positive matches, but a really robust method would require substantially more code I think. I might work on that too though because I think I have an idea of how that might work.
The second commit reduces the amount of text that would be highlighted/underlined by compilation mode when that regex does match. This version only underlines the filename and line number rather than the entire panic message.