search

rust-lang / rust-mode

Emacs configuration for Rust
Apache License 2.0
1.13k stars 181 forks source link

Fix ancient defect and dependency complications related to having two rust-mode implementations #534

Closed tarsius closed 8 months ago

tarsius commented 8 months ago 
lib/rust-mode/rust-mode-treesitter.el:21:33: Warning: reference to free variable ‘rust-before-save-hook’
lib/rust-mode/rust-mode-treesitter.el:22:32: Warning: reference to free variable ‘rust-after-save-hook’

and

lib/rust-mode/rust-rustfmt.el:60:12: Warning: ‘unwind-protect’ without unwind forms
psibi commented 8 months ago

@jroimartin / @condy0919 Can you also test drive this PR since you have had related issues previously ?

condy0919 commented 8 months ago

@jroimartin / @condy0919 Can you also test drive this PR since you have had related issues previously ?

My pleasure.

jroimartin commented 8 months ago

@jroimartin / @condy0919 Can you also test drive this PR since you have had related issues previously ?

@psibi it seems to work fine on my side.

psibi commented 8 months ago

I'm merging this since I have seen no objections from others. Thanks @tarsius for the PR! Thanks @condy0919 and @jroimartin for the additional testing.

tarsius commented 8 months ago

You're welcome!