search

rust-lang / rust-playground

The Rust Playground
https://play.rust-lang.org/
Apache License 2.0
1.24k stars 206 forks source link

Make Design Match Website #443

Open mitsuhiko opened 5 years ago

mitsuhiko commented 5 years ago

Now that the rust website has a new style maybe it would make sense to update the playpen to match. The new design is quite easy to adopt. In particular it would be awesome to have a minimalist mode that makes the playpen embeddable in an iframe.

shepmaster commented 5 years ago

the playpen

If you'd like to make changes to the playpen, you'll want a different repository, although the playpen has been deprecated for over a year now.

The new design is quite easy to adopt.

What should be changed? Please provide concrete suggestions or mockups.

Are other Rust properties (such as the docs) being changed?

Notably, the group in charge of the redesign hasn't made any notes about this change.

a minimalist mode that makes the playpen embeddable in an iframe

What does that have to do with making the style match? Sounds like a separate request.

mitsuhiko commented 5 years ago

I figured this still has the same name. I mostly wanted to know if contributions would be accepted that update the design to match.

I’m unaffiliated with either project but I wanted to see if the playground could be improved so that it can be embedded somewhere which sparked the issue I made.

shepmaster commented 5 years ago

contributions would be accepted that update the design to match.

They might be; it's hard to tell without seeing them. Ideally, I'd like to see the style guide for the website to understand how the choices of colors / fonts / spacing / etc are made as opposed to just a PR that is "copy some colors from one website to another".

The new Rust website is also deliberately aimed at a marketing focus (see all the people complaining about it in various locations) while the playground is highly focused on the developer. That's another reason that it may not make sense to change the style.

I don't think that the playground ever matched the main website's style. The design has always been one of the oldest issues (#26 / #25) and there's been little community interest in improving it.

so that it can be embedded somewhere

Again, I think that's a separate issue than simply updating the style, so I'd rather you open a separate feature request.

By offering embedding, people will then want a myriad of other options ("how do I prevent this option from changing", "how do I retheme it to match my site", etc.). It's also yet another public API that can never be removed from the playground without breaking the greater web.