Open miaomiao1992 opened 1 year ago
Yes, the current implementation expects to communicate with the Docker instance in part by writing files to disk from the server and then reading them inside the container (and vice-versa for the result). Experimentation showed that we needed to apply some permissions changes for that to work.
Work is progressing on a re-implementation where we will likely only communicate to the Docker container via stdin/out, which should magically fix this problem.
In the short term, try commenting that code out and seeing how running it works. It may not be needed at all on Windows, or it may need some alternative. Happy to review a PR with the results.
The ExitStatusExt
is trickier. The container definitely runs Linux commands and we get the Linux exit code. We smuggle that through the Docker layer and re-attach it to propagate upwards. It's possible we may only need a simple success/failure indicator instead of the full-blown exit code though.
Ditto for experimentation and future PR.
it seems only linux can deploy the server.