search

rust-lang / rust-semverver

Automatic checking for semantic versioning in library crates
BSD 3-Clause "New" or "Revised" License
639 stars 41 forks source link

Who should review new PRs? #137

Closed Xanewok closed 2 years ago

Xanewok commented 3 years ago

In an effort to streamline reviewing, this repository was moved to the rust-lang organization (from legacy the rust-dev-tools one) in order to use the @bors bot (similar to other repos under rust-lang org). While this should be now complete, there remains a question who should be reviewing the PRs :sweat_smile:

@Manishearth has helped me as an interim reviewer but we discussed on Discord that it'd be good to establish others instead as reviewers.

@ibabushkin @gnzlbg @JohnTitor do you have time and would like to review any new PRs? If not, do you have an idea who could?

Disclaimer: I'm trying to integrate semverver into https://github.com/paritytech/cargo-unleash for automatic workspace package publishing, hence why I'm interested in refreshing semverver a bit :slightly_smiling_face:

JohnTitor commented 3 years ago

I'm happy to help maintain since libc CI also uses this crate and I'm also interested in the updates :)

Manishearth commented 3 years ago

@Xanewok i'm happy for you and ilya to be reviewing, and y'all can choose additional reviewers if you'd like.

Xanewok commented 3 years ago

@JohnTitor you should now have bors review permissions as per https://github.com/rust-lang/team/pull/486 :slightly_smiling_face:

JohnTitor commented 3 years ago

@Xanewok Thanks! Feel free to r? or ping me if a review is needed :)

JohnTitor commented 3 years ago

Semi-related to this: It'd be great if the reviewers also have permission on the repo. I currently cannot edit/close PRs/issues like https://github.com/rust-lang/rust-semverver/pull/177 :(

Xanewok commented 3 years ago

@pietroalbini is it possible to do this via rust-lang/team?

Manishearth commented 3 years ago

@Xanewok has admin rights on the repo and can add others for edit/triage access, fwiw

Xanewok commented 3 years ago

Oh right, thanks. @JohnTitor can you see if you have access to triage features?

JohnTitor commented 3 years ago

@Xanewok Yep, thanks!

JohnTitor commented 2 years ago

Currently, reviewing is done by me and sometimes @Xanewok, closing.