Open Mingun opened 2 years ago
@rustbot label +A-code-coverage
I'm also experiencing the same issues. Producing the coverage locally and using the VSCode coverage gutters extension to view it shows much cleaner coverage information. So perhaps this is an issue on codecov's end?
I do not know in what part the problem begins, so if rustc has nothing to do with it, please tell me how to check that. I'm a maintainer of quick-xml and I setup a coverage for it and collect coverage, using
RUSTFLAGS: -C instrument-coverage
.However, results on codecov.io looks very strange:
use
s ormod
declarations marked as not covered (in the same place)#[cfg(test)]
modules) are also included in coverage which is unexpected, for example: https://app.codecov.io/gh/tafia/quick-xml/blob/master/src/de/mod.rs. That code should be used to produce coverage, not for coverage. This seriously biases the results, especially when you have more lines with tests than with code itself.Meta
The coverage is collected by GitHub
ubuntu-latest
runner, currently it reports Rust 1.64.0, but the issue was there since coverage was added to quick-xml, i.e. at least since 2022-05-30. The corresponding GitHub Actions file: https://github.com/tafia/quick-xml/blob/240f2049aec50876b6e13e632120b20cd60a37af/.github/workflows/rust.yml