search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
97.82k stars 12.66k forks source link

Tracking Issue for `x suggest` #109933

Open Ezrashaw opened 1 year ago

Ezrashaw commented 1 year ago

Tracking issue for x suggest subcommand and implementation of recommendations. Note that this isn't a traditional tracking issue for a feature but just a place to keep track of implementation.

See the zulip stream and the initial issue for more information and rationale about this change.

cc @albertlarsan68 @jyn514

Ezrashaw commented 1 year ago

@rustbot label +E-easy +E-mentor +E-help-wanted +T-bootstrap

albertlarsan68 commented 1 year ago

I think @rust-lang/libs @rust-lang/compiler should participate. @rustbot label +T-libs +T-compiler

DavidCoy77 commented 12 months ago

Hi! I'd love to get started contributing to Rust, but I'd need a little help getting started since this would be my first ever GitHub contribution. You've included the tags Easy, Help-Wanted, and Mentor, so if you're willing to help, I'm eager to get to work. Thanks!

onur-ozkan commented 12 months ago

I don't have the time for mentoring these days(moving my apartment).

DavidCoy77 commented 12 months ago

No problem @onur-ozkan

Dylan-DPC commented 11 months ago

@DavidCoy77 if you are still interested in this, you can claim the issue by commenting with @rustbot claim and then ask for help on zulip

albertlarsan68 commented 10 months ago

@DavidCoy77, if you still are looking for mentorship on this issue, DM me on Zulip, and we can talk about it.

hrkskov commented 9 months ago

Hi. I'm also interested in this issue as the first time for contribution to rust!

@DavidCoy77 Can I work on this?

ismailarilik commented 2 weeks ago

Image

Do we want this? =) And if we want, what should it check?

Ezrashaw commented 2 weeks ago

Do we want this? =) And if we want, what should it check?

Thanks for the interest! When I wrote the "static suggestions" code, I was vaguely thinking that there could be issues with this code turning into spaghetti and not being formatted correctly (with macros and all). So I thought that a tidy lint could enforce a common style or such like. https://github.com/rust-lang/rust/blob/9ff5fc4ffbbe1e911527aa054e789b05ae55ffcc/src/tools/suggest-tests/src/static_suggestions.rs#L16-L40 That hasn't happened yet, since there aren't that many suggestions, so there's probably not too much point doing work on this until there are more, and a better defined format for defining suggestions is implemented (like in a separate text file?)

I think that the most useful thing with this tool is to increase its coverage, but I'd definitely be happy if you wanted to write some sort of tidy lint for it.