rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.58k stars 12.74k forks source link

Automated handling of busted assembly tests #110751

Open workingjubilee opened 1 year ago

workingjubilee commented 1 year ago

There are assembly tests we know in advance are busted.

They

We could lint these automatically and probably should.

Ezrashaw commented 1 year ago

are neither #![no_core] or #![no_std], and do not -Zbuild-std are testing assembly generation of the compiler, and especially including asm!

Could you elaborate? I think that the test in my recent PR checks both of these boxes but is still useful.

As an aside, do you think this should be implemented in tidy or compiletest itself?

workingjubilee commented 1 year ago

That entire list is a single logical constraint.

workingjubilee commented 1 year ago

No idea on where this code could/should live, that feels like a vibes decision.

thomcc commented 1 year ago

compiletest is used out of tree (sort of) so probably tidy is more appropriate for this kind of thing.