rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
96.62k stars 12.48k forks source link

Tracking Issue for ARM CRC32 intrinsics #117215

Open Amanieu opened 10 months ago

Amanieu commented 10 months ago

Feature gate: #![feature(stdarch_arm_crc32)]

This is a tracking issue CRC32 intrinsics on ARM and AArch64.

Public API

// core::arch::{arm,aarch64}

pub unsafe fn __crc32b(crc: u32, data: u8) -> u32;
pub unsafe fn __crc32cb(crc: u32, data: u8) -> u32;
pub unsafe fn __crc32h(crc: u32, data: u16) -> u32;
pub unsafe fn __crc32ch(crc: u32, data: u16) -> u32;
pub unsafe fn __crc32w(crc: u32, data: u32) -> u32;
pub unsafe fn __crc32cw(crc: u32, data: u32) -> u32;

// core::arch::aarch64

pub unsafe fn __crc32d(crc: u32, data: u64) -> u32;
pub unsafe fn __crc32cd(crc: u32, data: u64) -> u32;

Steps / History

Unresolved Questions

Jules-Bertholet commented 10 months ago

@rustbot label o-aarch64 o-arm a-simd

Amanieu commented 6 months ago

These intrinsics are documented as part of the ARM C language extensions.

@rfcbot fcp merge

rfcbot commented 6 months ago

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot commented 6 months ago

:bell: This is now entering its final comment period, as per the review above. :bell:

rfcbot commented 6 months ago

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.