search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
97.96k stars 12.69k forks source link

Tracking Issue for AArch64 SHA3 intrinsics #117225

Open Amanieu opened 12 months ago

Amanieu commented 12 months ago

Feature gate: #![feature(stdarch_neon_sha3)]

This is a tracking issue for NEON intrinsics under the sha3 feature.

Public API

// core::arch::aarch64

fn veor3q*(..);
fn vbcaxq*(..);
fn vrax1q*(..);
fn vsha512*(..);

Steps / History

Unresolved Questions

Jules-Bertholet commented 12 months ago

@rustbot label o-aarch64 a-simd

tarcieri commented 7 months ago

I'm interested in helping stabilize vsha512*.

I saw vsha256* was stabilized in https://github.com/rust-lang/stdarch/pull/1399. Is all that's needed a similar stabilization PR? (although possibly without the not(target_arch = "arm") gating since it's AArch64-specific anyway?)

Amanieu commented 7 months ago

Yes, just submit a stabilization PR and then we can start an FCP.

tarcieri commented 7 months ago

It looks like since it's autogenerated code, stabilizing vsha512* would involve stabilizing all of stdarch_neon_sha3 by modifying this line, which I can open a PR for: https://github.com/rust-lang/stdarch/blob/3961d3b/crates/stdarch-gen-arm/src/main.rs#L532

tarcieri commented 7 months ago

Opened a PR: https://github.com/rust-lang/stdarch/pull/1552