Update Android in CI

[maurer]

We are currently using a 10+ year old Android image, and it has caused trouble when working on #120326.

Our current NDK (25) only supports API 19+, so we were already out of spec. This PR:

1. Bumps the API used by the emulator in CI to 21, as per NDK-26's release notes deprecating 19 and 20 as targets.
2. Activates aarch64 testing on the emulator, since the base image is now a 64-bit image.
3. Bumps the NDK to 26b

[rustbot]

r? @Kobzol

(rustbot has picked a reviewer for you, use r? to override)

[maurer]

r? @pietroalbini

Pietro, I've added you explicitly since you're the only one to ever touch this lockfile, which means you're likely to be the one who can run update-mirror, which I lack the credentials for.

[maurer]

cc @chriswailes

[Mark-Simulacrum]

The new files should be uploaded to the mirror. However, I'd like to get a +1 from another android target maintainer on this PR before moving ahead.

cc @chriswailes @mgeisler (per platform support docs)

[workingjubilee]

Happy to see this land, as it looks like it will also allow simplifying away https://github.com/rust-lang/backtrace-rs/pull/570 from backtrace-rs, too.

[maurer]

ping @Mark-Simulacrum - it looks like it still says "waiting on author", but Chris has LGTM'd.

[workingjubilee]

@rustbot ready

[Mark-Simulacrum]

@bors r+ rollup=iffy

[bors]

:pushpin: Commit 7c39eee98f853611ff42da35bb3af9a66180eadc has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

:hourglass: Testing commit 7c39eee98f853611ff42da35bb3af9a66180eadc with merge 23c8dec56714406a898fcc56742ba5708546a693...

[bors]

:broken_heart: Test failed - checks-actions

[rust-log-analyzer]

The job dist-android failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

```plain ```

[workingjubilee]

Failed about here, it seems:

 Executing python3 ../x.py dist --host= --target arm-linux-androideabi,armv7-linux-androideabi,thumbv7neon-linux-androideabi,i686-linux-android,aarch64-linux-android,x86_64-linux-android
+ python3 ../x.py dist --host= --target arm-linux-androideabi,armv7-linux-androideabi,thumbv7neon-linux-androideabi,i686-linux-android,aarch64-linux-android,x86_64-linux-android
Building bootstrap
      Finished `dev` profile [unoptimized] target(s) in 0.04s
thread 'main' panicked at src/core/sanity.rs:59:13:

couldn't find required command: "/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi19-clang"

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[maurer]

I missed the cc_detect logic the first time around - it was still attempting to pick an API 19 linker for 32-bit.

@rustbot ready

[rustbot]

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

[workingjubilee]

@bors r=Mark-Simulacrum,workingjubilee

[bors]

:pushpin: Commit a9724f36febccbbc24b7c38975df1b3d52ea05e2 has been approved by Mark-Simulacrum,workingjubilee

It is now in the queue for this repository.

[workingjubilee]

The change in cc_detect caused me to inspect and notice that config.toml.example had a ref to n25b so I asked maurer to update that, which led to the etc. etc. There are some other necessary followups too, but this CI change should land independently.

[bors]

:hourglass: Testing commit a9724f36febccbbc24b7c38975df1b3d52ea05e2 with merge cc89f616fb86b6a981160880f78e88c839bbf4ee...

[bors]

:boom: Test timed out

[workingjubilee]

The fact this timeout was on, specifically, the aarch64-android job, makes me feel like this was not a spurious error, but I have no proof for that.

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

```plain ```

[maurer]

Seems possible that it's a real failure. Are you aware of any workflows for trying to reproduce locally? I would have expected that even a timeout would have logs leading up to the failing step...

[Mark-Simulacrum]

https://rustc-dev-guide.rust-lang.org/tests/docker.html

https://github.com/rust-lang-ci/rust/actions/runs/8411885535/job/23032016177 for the logs.

[workingjubilee]

The logs just terminate somewhat cryptically here:

Building stage2 library artifacts (x86_64-unknown-linux-gnu -> arm-linux-androideabi)
[TIMING] core::build_steps::compile::Std { target: arm-linux-androideabi, compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu }, crates: [], force_recompile: false, extra_rust_args: [], is_for_mir_opt_tests: false } -- 46.623
REMOTE copy libs to emulator (arm-linux-androideabi)
Building stage2 tool remote-test-server (x86_64-unknown-linux-gnu -> arm-linux-androideabi)
     Compiling remote-test-server v0.1.0 (/checkout/src/tools/remote-test-server)
  [RUSTC-TIMING] remote_test_server test:false 0.682
      Finished `release` profile [optimized] target(s) in 0.85s
[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu }, target: arm-linux-androideabi, tool: "remote-test-server", path: "src/tools/remote-test-server", mode: ToolStd, source_type: InTree, extra_features: [], allow_features: "" } -- 0.864
[TIMING] core::build_steps::tool::RemoteTestServer { compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu }, target: arm-linux-androideabi } -- 0.001
Building stage0 tool remote-test-client (x86_64-unknown-linux-gnu)
     Compiling remote-test-client v0.1.0 (/checkout/src/tools/remote-test-client)
  [RUSTC-TIMING] remote_test_client test:false 0.579
      Finished `release` profile [optimized] target(s) in 0.73s
[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target: x86_64-unknown-linux-gnu, tool: "remote-test-client", path: "src/tools/remote-test-client", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "" } -- 0.746
[TIMING] core::build_steps::tool::RemoteTestClient { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target: x86_64-unknown-linux-gnu } -- 0.001
waiting for device to come online
* daemon not running; starting now at tcp:5037
* daemon started successfully
Error: The operation was canceled.

The log analyzer decided not to report it because its heuristics meant this was decided to not be very informative, which... is correct, honestly. With a "wonderful" log report like that, it's hard to actually rule out anything. Though, it probably should have decided to just fork over those last few lines anyways.

[bors]

:umbrella: The latest upstream changes (presumably #124026) made this pull request unmergeable. Please resolve the merge conflicts.

[workingjubilee]

@bors r-

[Dylan-DPC]

@maurer any updates on this? thanks

[maurer]

Sorry, I've been on vacation for the last two weeks. I should have a chance to investigate this further some time this week.

[maurer]

Brief update:

1. We're going to need to upload emulator emulator-linux_x64-11772612.zip 974ad0591834a9fa3db307e49cdba352462e5f1e - the emulator that was in the previous change has a bug when running in headless mode that leads to segfaults/crashes
2. The aarch64 development image does not support 32-bit execution. We'll need a separate system-images;android-21;default;armeabi-v7a.

Would folks prefer: a. Updating the android builder to launch two VMs, and do both arm32 and aarch64 testing on them b. Split into two builders, and keep to the 'one external runner per builder' paradigm that's been in use.

As far as I can tell, b is closer to what we've done elsewhere, so it's what I'll configure if I don't hear otherwise. I'll update the change once I have something passing (with the caveat of a hack I'll need until the mirror is updated).

[rustbot]

Some changes occurred in tests/codegen/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

[rust-log-analyzer]

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

```plain Getting action download info Download action repository 'msys2/setup-msys2@v2.22.0' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea) Download action repository 'actions/checkout@v4' (SHA:0ad4b8fadaa221de15dcec353f45205ec38ea70b) Download action repository 'actions/upload-artifact@v4' (SHA:65462800fd760344b1a7b4382951275a0abb4808) Complete job name: PR - mingw-check-tidy git config --global core.autocrlf false shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0} --- COPY scripts/sccache.sh /scripts/ RUN sh /scripts/sccache.sh COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/ RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \ && pip3 install virtualenv COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/ COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/ # NOTE: intentionally uses python2 for x.py so we can test it still works. # NOTE: intentionally uses python2 for x.py so we can test it still works. # validate-toolstate only runs in our CI, so it's ok for it to only support python3. ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \ --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint # This file is autogenerated by pip-compile with Python 3.10 # by the following command: # # pip-compile --allow-unsafe --generate-hashes reuse-requirements.in --- #12 [5/8] COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/ #12 DONE 0.0s #13 [6/8] RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt && pip3 install virtualenv #13 0.429 Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB) #13 0.440 Collecting boolean-py==4.0 #13 0.443 Downloading boolean.py-4.0-py3-none-any.whl (25 kB) #13 0.455 Collecting chardet==5.1.0 --- #13 5.090 Downloading virtualenv-20.26.1-py3-none-any.whl (3.9 MB) #13 5.143 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.9/3.9 MB 77.7 MB/s eta 0:00:00 #13 5.194 Collecting filelock<4,>=3.12.2 #13 5.198 Downloading filelock-3.14.0-py3-none-any.whl (12 kB) #13 5.214 Collecting distlib<1,>=0.3.7 #13 5.217 Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB) #13 5.223 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.9/468.9 KB 129.3 MB/s eta 0:00:00 #13 5.251 Collecting platformdirs<5,>=3.9.1 #13 5.256 Downloading platformdirs-4.2.1-py3-none-any.whl (17 kB) #13 5.344 Installing collected packages: distlib, platformdirs, filelock, virtualenv #13 5.509 Successfully installed distlib-0.3.8 filelock-3.14.0 platformdirs-4.2.1 virtualenv-20.26.1 #13 DONE 5.6s #14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/ #14 DONE 0.0s --- DirectMap4k: 194496 kB DirectMap2M: 7145472 kB DirectMap1G: 11534336 kB ##[endgroup] Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint + TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint Finished `dev` profile [unoptimized] target(s) in 0.03s ##[endgroup] downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/b923ea4924fede68af127ac1857dcb0382e4caf9/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz extracting /checkout/obj/build/cache/llvm-b923ea4924fede68af127ac1857dcb0382e4caf9-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm --- ##[endgroup] fmt check tidy check tidy: Skipping binary file check, read-only filesystem removing old virtual environment creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (24.0) Collecting black==23.3.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 7)) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 53.1 MB/s eta 0:00:00 Collecting click==8.1.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 34)) Downloading click-8.1.3-py3-none-any.whl (96 kB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 96.6/96.6 kB 39.1 MB/s eta 0:00:00 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 96.6/96.6 kB 39.1 MB/s eta 0:00:00 Collecting importlib-metadata==6.7.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 38)) Downloading importlib_metadata-6.7.0-py3-none-any.whl (22 kB) Collecting mypy-extensions==1.0.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 42)) Downloading mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB) Collecting packaging==23.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 46)) Downloading packaging-23.1-py3-none-any.whl (48 kB) Collecting pathspec==0.11.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 50)) Downloading pathspec-0.11.1-py3-none-any.whl (29 kB) Collecting platformdirs==3.6.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 54)) Downloading platformdirs-3.6.0-py3-none-any.whl (16 kB) Downloading platformdirs-3.6.0-py3-none-any.whl (16 kB) Collecting ruff==0.0.272 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 58)) Downloading ruff-0.0.272-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.9 MB) Collecting tomli==2.0.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 77)) Downloading tomli-2.0.1-py3-none-any.whl (12 kB) Collecting typed-ast==1.5.4 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 81)) Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB) Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 877.7/877.7 kB 108.1 MB/s eta 0:00:00 Collecting typing-extensions==4.6.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 107)) Downloading typing_extensions-4.6.3-py3-none-any.whl (31 kB) Collecting zipp==3.15.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 114)) Downloading zipp-3.15.0-py3-none-any.whl (6.8 kB) Installing collected packages: zipp, typing-extensions, typed-ast, tomli, ruff, platformdirs, pathspec, packaging, mypy-extensions, click, importlib-metadata, black Successfully installed black-23.3.0 click-8.1.3 importlib-metadata-6.7.0 mypy-extensions-1.0.0 packaging-23.1 pathspec-0.11.1 platformdirs-3.6.0 ruff-0.0.272 tomli-2.0.1 typed-ast-1.5.4 typing-extensions-4.6.3 zipp-3.15.0 linting python files /checkout/src/ci/docker/scripts/android-sdk-manager.py:147:9: F841 [*] Local variable `url` is assigned to but never used Found 1 error. [*] 1 potentially fixable with the --fix option. python linting failed! Printing diff suggestions: --- /checkout/src/ci/docker/scripts/android-sdk-manager.py +++ /checkout/src/ci/docker/scripts/android-sdk-manager.py @@ -144,7 +144,7 @@ for package in lockfile.packages.values(): # Download the file from the mirror into a temp file - url = "https://" + MIRROR_BUCKET + ".s3-" + MIRROR_BUCKET_REGION + \ + "https://" + MIRROR_BUCKET + ".s3-" + MIRROR_BUCKET_REGION + \ + "https://" + MIRROR_BUCKET + ".s3-" + MIRROR_BUCKET_REGION + \ ".amazonaws.com/" + MIRROR_BASE_DIR # DO NOT SUBMIT - need updates first downloaded = package.download(BASE_REPOSITORY) Would fix 1 error. tidy error: checks with external tool 'ruff' failed some tidy checks failed local time: Tue May 7 21:00:54 UTC 2024 network time: Tue, 07 May 2024 21:00:54 GMT ##[error]Process completed with exit code 1. Post job cleanup. ```

[maurer]

@Mark-Simulacrum , since you uploaded the files last time (so I know you have the power), can you upload with both .lock files (now that I created two of them, with different contents)? Once that's done, I'll pull the two hack commits I've got on for testing off and we should finally be good.

@rustbot ready (It is not actually ready, but it requires reviewer action to progress)

[Mark-Simulacrum]

Happy to upload some files to our mirror, but I'm not sure where I should mirror them from or exactly which files need to be uploaded. Can you clarify?

[maurer]

Specifically, I would like you to run:

src/ci/docker/scripts/android-sdk-manager.py update-mirror src/ci/docker/host-x86_64/aarch64-android/android-sdk.lock
src/ci/docker/scripts/android-sdk-manager.py update-mirror src/ci/docker/host-x86_64/arm-android/android-sdk.lock

with this CL pulled down.

This will fetch the Android images + emulator from google's repositories and upload them to your buckets. I'll then drop DO NOT SUBMIT: Hack SDK manager to not use buckets from the PR to make sure it worked (let GHA run), and then drop DO NOT SUBMIT - force run aarch64-android and arm-android and it should be good for submission.

[Mark-Simulacrum]

Alright, that should be done.

[maurer]

OK, ready for review - I've stripped both hack commits off.

• aarch64 run
• arm run

[bors]

:umbrella: The latest upstream changes (presumably #123337) made this pull request unmergeable. Please resolve the merge conflicts.

[workingjubilee]

@maurer sorry about that, can you rebase this?

[Mark-Simulacrum]

@bors r+ rollup=never

[bors]

:pushpin: Commit c1ac0c8cfb95e129466aefa79d6a5bb324609668 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

:hourglass: Testing commit c1ac0c8cfb95e129466aefa79d6a5bb324609668 with merge 5b05a5aed7696ccb3d8487d528bc997aa7a175b4...

[rust-log-analyzer]

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

```plain test [ui] tests/ui/consts/raw-ptr-temp-const.rs ... ok test [ui] tests/ui/consts/promotion-mutable-ref.rs ... ok test [ui] tests/ui/consts/recursive-zst-static.rs#unleash ... ok test [ui] tests/ui/consts/recursive-zst-static.rs#default ... ok ##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled. test [ui] tests/ui/consts/refs-to-cell-in-final.rs ... ok test [ui] tests/ui/consts/recursive.rs ... ok test [ui] tests/ui/consts/refs_check_const_eq-issue-88384.rs ... ok Session terminated, killing shell...::group::Clock drift check test [ui] tests/ui/consts/required-consts/collect-in-called-fn.rs#opt ... ok test [ui] tests/ui/consts/required-consts/collect-in-dead-closure.rs#noopt ... ok test [ui] tests/ui/consts/required-consts/collect-in-dead-closure.rs#opt ... ok test [ui] tests/ui/consts/required-consts/collect-in-called-fn.rs#noopt ... ok ```

[bors]

:broken_heart: Test failed - checks-actions

[Mark-Simulacrum]

@bors retry

aarch64 runner reboot

[bors]

:hourglass: Testing commit c1ac0c8cfb95e129466aefa79d6a5bb324609668 with merge bb06083720fb43d8cc4f4b948769f06c68d54265...

[rust-log-analyzer]

The job aarch64-android failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

```plain COPY scripts/sccache.sh /scripts/ RUN sh /scripts/sccache.sh COPY scripts/android-start-emulator.sh /scripts/ ENTRYPOINT ["/scripts/android-start-emulator.sh", "arm64-v8a", "auto"] emulator emulator-linux_x64-11772612.zip 974ad0591834a9fa3db307e49cdba352462e5f1e platform-tools platform-tools_r34.0.5-linux.zip 96097475cf7b279fdd8f218f5d043ffe94104ec3 platforms;android-21 android-21_r02.zip 53536556059bb29ae82f414fd2e14bc335a4eb4c platforms;android-21 android-21_r02.zip 53536556059bb29ae82f414fd2e14bc335a4eb4c system-images;android-21;default;arm64-v8a sys-img/android/arm64-v8a-21_r04.zip c4375f1b4b4cd21a8617660e25f621cedcbd8332 #!/bin/sh set -ex apt-get update --- # Setting SHELL to a file instead on a symlink helps android # emulator identify the system export SHELL=/bin/bash nohup nohup emulator @$1-21 \ -engine $2 -no-window -no-audio -partition-size 2047 0<&- &>/dev/null & shift 2 exec "$@" #!/bin/sh --- ##[endgroup] + export SHELL=/bin/bash + + shift 2 + exec /checkout/src/ci/run.sh nohup nohup emulator @arm64-v8a-21 -engine auto -no-window -no-audio -partition-size 2047 [CI_JOB_NAME=aarch64-android] WARNING: engine selection is deprecated. WARNING: engine selection is deprecated. INFO | Storing crashdata in: /tmp/android-unknown/emu-crash-34.2.13.db, detection is enabled for process: 8 INFO | Android emulator version 34.2.13.0 (build_id 11772612) (CL:N/A) INFO | Found systemPath /android/sdk/system-images/android-21/default/arm64-v8a/ --- downloading https://static.rust-lang.org/dist/2024-04-29/cargo-beta-x86_64-unknown-linux-gnu.tar.xz extracting /checkout/obj/build/cache/2024-04-29/rust-std-beta-x86_64-unknown-linux-gnu.tar.xz extracting /checkout/obj/build/cache/2024-04-29/rustc-beta-x86_64-unknown-linux-gnu.tar.xz extracting /checkout/obj/build/cache/2024-04-29/cargo-beta-x86_64-unknown-linux-gnu.tar.xz WARNING | encryption is off WARNING | FeatureControl is requesting a non existing feature. ERROR | Unable to connect to adb daemon on port: 5037 WARNING | FeatureControl is requesting a non existing feature. WARNING | Your GPU drivers may have a bug. Switching to software rendering. WARNING: could not open libX11.so, try libX11.so.6 WARNING: cannnot unmap ptr 0x7fb9961ba000 as it is in the protected range from 0x7fb9961ba000 to 0x7fb9d63ba000 WARNING: cannnot unmap ptr 0x7fb9d6201000 as it is in the protected range from 0x7fb9961ba000 to 0x7fb9d63ba000 WARNING | Using fallback path for the emulator registration directory. WARNING | The emulator now requires a signed jwt token for gRPC access! Use the -grpc flag if you really want an open unprotected grpc port WARNING | *** Basic token auth should only be used by android-studio *** WARNING | Using fallback path for the emulator registration directory. WARNING | Failed to process .ini file /root/.android/emu-update-last-check.ini for reading. WARNING | Device 'userdata' does not have the requested snapshot 'default_boot' WARNING | Failed to load snapshot 'default_boot' WARNING | Cold boot based on user configuration WARNING | Failed to process .ini file /root/.android/emu-update-last-check.ini for reading. Updating crates.io index --- collections::vec_deque::tests::test_range test result: FAILED. 400 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 49.00s error: test failed, to rerun pass `-p alloc --lib` local time: Mon May 20 00:49:10 UTC 2024 network time: Mon, 20 May 2024 00:49:10 GMT ##[error]Process completed with exit code 1. Post job cleanup. ```

[bors]

:broken_heart: Test failed - checks-actions

[workingjubilee]

oddly specific failure.

[maurer]

That looks like a pointer getting used as an index - that number is 0xffffff8aee5d1001. I don't think it's related to anything in this CL, but I can try re-running things manually tomorrow...

The one thing that it could be in this change is that aarch64-android is using a new emulator, which means a different version of qemu. The probe tests I ran should have found that though, unless we had a codegen change in the last ~week that this emulator mis-executes.