Closed calebsander closed 1 week ago
r? @Mark-Simulacrum
rustbot has assigned @Mark-Simulacrum. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r?
to explicitly pick a reviewer
These commits modify the Cargo.lock
file. Unintentional changes to Cargo.lock
can be introduced when switching branches and rebasing PRs.
If this was unintentional then you should revert the changes before this PR is merged. Otherwise, you can ignore this comment.
r? @dtolnay
@bors r+
This ensures the version of
time
used inrustc
includes this change: https://github.com/time-rs/time/pull/671. This fix is a necessary prerequisite for #99969, which addsFromIterator
implementations forBox<str>
. Previously,time
had anInto::into
that resolved to the identity impl, followed by acollect::<Result<Box<_>, _>>()
. With the newFromIterator
implementations forBox<str>
, theInto::into
resolution is ambiguous and time fails to compile. Thanks to @dtolnay for the analysis in https://github.com/rust-lang/rust/pull/99969#issuecomment-2001422230. Thetime
fix removes the identityInto::into
conversion, allowingtime
to compile with the newFromIterator
implementations. This version oftime
also matches whatcargo
recently switched to in https://github.com/rust-lang/cargo/pull/13834.