rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
93.58k stars 12.05k forks source link

compiler: upgrade time from 0.3.34 to 0.3.36 #124736

Closed calebsander closed 1 week ago

calebsander commented 1 week ago

This ensures the version of time used in rustc includes this change: https://github.com/time-rs/time/pull/671. This fix is a necessary prerequisite for #99969, which adds FromIterator implementations for Box<str>. Previously, time had an Into::into that resolved to the identity impl, followed by a collect::<Result<Box<_>, _>>(). With the new FromIterator implementations for Box<str>, the Into::into resolution is ambiguous and time fails to compile. Thanks to @dtolnay for the analysis in https://github.com/rust-lang/rust/pull/99969#issuecomment-2001422230. The time fix removes the identity Into::into conversion, allowing time to compile with the new FromIterator implementations. This version of time also matches what cargo recently switched to in https://github.com/rust-lang/cargo/pull/13834.

rustbot commented 1 week ago

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot commented 1 week ago

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged. Otherwise, you can ignore this comment.

calebsander commented 1 week ago

r? @dtolnay

dtolnay commented 1 week ago

@bors r+

bors commented 1 week ago

:pushpin: Commit 43c8e139fd36c83711e3f2331153f7c2065ff1df has been approved by dtolnay

It is now in the queue for this repository.

bors commented 1 week ago

:evergreen_tree: The tree is currently closed for pull requests below priority 9999. This pull request will be tested once the tree is reopened.