Closed madsmtm closed 1 week ago
r? @lcnr
rustbot has assigned @lcnr. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r?
to explicitly pick a reviewer
These commits modify compiler targets. (See the Target Tier Policy.)
looking through this, pretty certain that this doesn't do any functional changes (so r=me on that front). Unsure whether this split is generally desirable/the state of apple abis more generally
r? compiler
lcnr says there are no functional changes, BlackHoleFox thinks this is an improvement, that sounds good. @bors r=lcnr,BlackHoleFox
:pushpin: Commit 8f0d35769de3b54a5fd95ac61ce6a3ec4144f5f7 has been approved by lcnr,BlackHoleFox
It is now in the queue for this repository.
:hourglass: Testing commit 8f0d35769de3b54a5fd95ac61ce6a3ec4144f5f7 with merge 2259028a70d6e1a44ad2cfd81955b577a43e8ef6...
:sunny: Test successful - checks-actions Approved by: lcnr,BlackHoleFox Pushing 2259028a70d6e1a44ad2cfd81955b577a43e8ef6 to master...
Finished benchmarking commit (2259028a70d6e1a44ad2cfd81955b577a43e8ef6): comparison URL.
@rustbot label: -perf-regression
This benchmark run did not return any relevant results for this metric.
This benchmark run did not return any relevant results for this metric.
This benchmark run did not return any relevant results for this metric.
Bootstrap: 675.209s -> 673.288s (-0.28%) Artifact size: 315.95 MiB -> 316.02 MiB (0.02%)
This was bundled together with
Arch
, which complicated a few code paths and meant we had to do more string matching than necessary.CC @BlackHoleFox as you've worked on the Apple target spec before
Related: Is there a reason why
Target
/TargetOptions
useStaticCow
for so many things, instead of an enum with defined values (and perhaps a catch-all case for custom target json files)? Tagging @Nilstrieb, as you might know?