search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
93.58k stars 12.05k forks source link

fix #124714 str.to_lowercase sigma handling #124773

Closed Marcondiro closed 1 week ago

Marcondiro commented 1 week ago

Hello, This PR fixes issue #124714 about 'Σ' handling in str.to_lowercase(). The fix consists in considering the full original string during 'Σ' handling instead of considering just the substring left after the optimized ascii handling. A new test is added to avoid regression. Thanks!

rustbot commented 1 week ago

r? @joboet

rustbot has assigned @joboet. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot commented 1 week ago

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

joboet commented 1 week ago

@rustbot author

Marcondiro commented 1 week ago

@rustbot review

Marcondiro commented 1 week ago

Maybe bors missed the command @joboet I think it wants an empty line before the command :)

bors commented 1 week ago

@Marcondiro: :key: Insufficient privileges: Not in reviewers

joboet commented 1 week ago

Let's try again then! @bors r+

bors commented 1 week ago

:pushpin: Commit bbdf97254a2ed63d764a39e92a3adcecc49b962b has been approved by joboet

It is now in the queue for this repository.

bors commented 1 week ago

:hourglass: Testing commit bbdf97254a2ed63d764a39e92a3adcecc49b962b with merge 238c1e798d371440847e53b5f00db86610d0e263...

bors commented 1 week ago

:sunny: Test successful - checks-actions Approved by: joboet Pushing 238c1e798d371440847e53b5f00db86610d0e263 to master...

rust-timer commented 1 week ago

Finished benchmarking commit (238c1e798d371440847e53b5f00db86610d0e263): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.5%, -0.4%] 5
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment. | | mean | range | count | |:----------------------------------:|:-----:|:--------------:|:-----:| | Regressions ❌
(primary) | - | - | 0 | | Regressions ❌
(secondary) | - | - | 0 | | Improvements ✅
(primary) | - | - | 0 | | Improvements ✅
(secondary) | -3.2% | [-3.2%, -3.2%] | 1 | | All ❌✅ (primary) | - | - | 0 |

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.785s -> 675.773s (0.15%) Artifact size: 315.96 MiB -> 315.82 MiB (-0.04%)