search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
97.19k stars 12.56k forks source link

bootstrap: sccache has no effect / RUSTC_WRAPPER not used? #128633

Open matthiaskrgr opened 1 month ago

matthiaskrgr commented 1 month ago

b389b0ab72cb0aa9acf4df0ae0c0e12090782da9

It seems that when doing a x.py build or check, RUSTC_WRAPPER is no longer used, so all calls go directly to rustc and not sccache rustc which would allow caching through sccache?

When building rustc, I could see that the sccache was neither utilized (no cache hits) nor fed with new artifacts (no cache misses)

bjorn3 commented 1 month ago

I am pretty sure that sccache will either not be effective (it doesn't cache when --sysroot is passed) or cause actual issues (like not invalidating the cache if the standard library gets changed) if it were to be used.

matthiaskrgr commented 1 month ago

I'm wondering if #126476 is related. :thinking:

@bjorn3 from just doing normal compiler bootstraps like x.py build/test/check I don't remember running into any frequent problems tbh :thinking: