search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.34k stars 12.72k forks source link

run-make: vendor cargo dependencies or external dependencies within the tests #128733

Open jieyouxu opened 3 months ago

jieyouxu commented 3 months ago

These tests use cargo to build crates but they have external dependencies -- this makes their pass/fail status conditioned on internet connectivity which does not seem ideal (and also if it's not pinned and it can become awkward from breakages..)

We should investigate if we could vendor the external deps or otherwise make them locally available to make the test outcomes more reproducible.

tdittr commented 3 months ago

For reference the this was discussed for thumb-none-qemu and thumb-none-cortex-m at an embedded WG meeting: https://github.com/rust-embedded/wg/discussions/783#discussioncomment-10257174