rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
96.66k stars 12.49k forks source link

Delete all code for handling lldb and gdb versions that don't support Rust natively #128953

Closed saethlin closed 3 weeks ago

saethlin commented 1 month ago

We have a fair bit of code in both src/tools/compiletest and tests/debuginfo devoted to handling the 7.X releases of gdb, because those had no built-in Rust support. But as of this year at least, the oldest supported RHEL version is now shipping gdb 8.2 so there's no reason for us to be pretending to support versions of gdb before 8.2.

The dev guide also vaguely indicates that this distinction for lldb shouldn't exist anymore:

https://github.com/rust-lang/rustc-dev-guide/blob/43d83780db545a1ed6d45773312fc578987e3968/src/tests/compiletest.md?plain=1#L216 https://github.com/rust-lang/rustc-dev-guide/blob/43d83780db545a1ed6d45773312fc578987e3968/src/tests/compiletest.md?plain=1#L253-L255

saethlin commented 3 weeks ago

Turns out the modern side of the version split for lldb is the version without Rust support. That's a bummer, but still the goal here is to delete unused code.