Open rustbot opened 1 month ago
@est31 What do you think about this compatibility notes?
# Compatibility Notes
- The future incompatibility lint `deprecated_cfg_attr_crate_type_name` [has been made into a hard error](https://github.com/rust-lang/rust/pull/129670). It was used to deny usage of `#![crate_type]` and `#![crate_name]` attributes in `#![cfg_attr]`, which required a hack in the compiler to be able to change the used crate type and crate name after macros have been expanded.
Users must now use `--crate-type` on the command line when running `rustc` instead of `#![cfg_attr(..., crate_type = "...")]` and `--crate-name` instead of `#![cfg_attr(..., crate_name = "...")]`.
I would write "Users can instead use" instead of "Users must now use" -- it's still entirely up to users what to do. They can also make separate crates where they include!()
lib.rs.
"after macros have been expanded." after cfg expansion. Maybe also add "Use of the attributes outside of #![cfg_attr]
is still supported.".
Sure, updated with your suggestions and tweaked a bit the sentences.
This issue tracks the release notes text for #129670.
Release notes text:
The section title will be de-duplicated by the release team with other release notes issues. Prefer to use the standard titles from previous releases. More than one section can be included if needed.
Release blog section (if any, leave blank if no section is expected):