Open kiike opened 1 month ago
If this is out-of-scope for configure.py and manual editing of the config.toml is required, I'd like to know too.
@rustbot label T-bootstrap
@onur-ozkan, I'd like to work on this. As the lead for the bootstrap phase, could you provide a couple hints on how you envision the change, i.e. the approach you would like this to take? I provided some patches in the first comment to show a couple of ways I could tackle this issue.
@onur-ozkan, I'd like to work on this. As the lead for the bootstrap phase, could you provide a couple hints on how you envision the change, i.e. the approach you would like this to take? I provided some patches in the first comment to show a couple of ways I could tackle this issue.
Hi, sorry for the late response. I wouldn't add any special logic for target names but would instead solve this more generally by handling dots within quotes (e.g., making it so that --set="target.thumbv8m.main-none-eabi.linker=/path/to/linker" works without issues).
When passing
--set
arguments to the configure script, the targets will be incorrectly detected when they include a dot in the name. An example would bethumbv8m.main
. Thus, when using a command line such asthis error will be triggered:
This is related to #97263 and #105920. I think there might be three different solutions:
Output:
Resulting in:
I'm wiling to work on this issue but I'd need to know what approach would be preferred.