search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
97.09k stars 12.55k forks source link

incorrect revision syntax is silently accepted #130815

Open lcnr opened 2 hours ago

lcnr commented 2 hours ago

https://github.com/rust-lang/rust/blob/1b5aa96d6016bafe50e071b45d4d2e3c90fd766f/tests/ui/traits/coherence-alias-hang.rs#L1-L5

This test never actually tests the new solver. It has to be //@[next] compile-flags: -Znext-solver. We should lint here ✨

jieyouxu commented 2 hours ago

Ah right. This is a bit like https://github.com/rust-lang/rust/issues/125813 (that issue is // @<directive> does nothing because it's not a valid compiletest directive syntax).