rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.61k stars 12.74k forks source link

Tracking issue for release notes of #83164: Tracking Issue for const_replace #131092

Open rustbot opened 1 month ago

rustbot commented 1 month ago

This issue tracks the release notes text for #83164.

Steps

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Category (e.g. Language, Compiler, Libraries, Compatibility notes, ...)
- [Tracking Issue for const_replace](https://github.com/rust-lang/rust/issues/83164)

[!TIP] Use the previous releases categories to help choose which one(s) to use. The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section. Otherwise leave it empty.

cc @usbalbin -- origin issue/PR authors and assignees for starting to draft text

usbalbin commented 1 month ago

Ping @workingjubilee since you did the stabilization PR #130954

Not sure how release notes work, should this be its own thing or part of some bigger constification thing like your PR?

workingjubilee commented 1 month ago

relnotes tag goes on the PR. That PR hasn't landed yet, so this shouldn't be in relnotes.

workingjubilee commented 1 month ago

...oh this happens automatically on a to-announce???

workingjubilee commented 1 month ago

geez, there's going to be like 10 of these...

RalfJung commented 1 month ago

...oh this happens automatically on a to-announce???

I think it happens on FCPs. But I am not sure what event exactly the bot is looking for.

mbartlett21 commented 1 month ago

It looks for labels of any of relnotes, relnotes-perf or finished-final-comment-period.

    if let IssuesAction::Labeled { label } = &e.action {
        if ["relnotes", "relnotes-perf", "finished-final-comment-period"]
            .contains(&label.name.as_str())
        {

https://github.com/rust-lang/triagebot/blob/f563bc9578ae26d825f0ab6b1255068afebe6a2a/src/handlers/relnotes.rs#L66-L69

workingjubilee commented 1 month ago

I... guess I'll do this then?