rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.61k stars 12.74k forks source link

Tracking Issue for `download-rustc` improvements #131744

Open onur-ozkan opened 1 month ago

onur-ozkan commented 1 month ago

These changes are necessary to make download-rustc more stable and less risky:

RalfJung commented 1 month ago

When not running in CI, if the "library" tree has changed but the "compiler" tree hasn't, avoid recompiling the "compiler" tree.

Isn't this premature? We can do this once the compiler uses the beta library, because then the library folder truly does not affect the stage 0 compiler artifacts. But today, library is an input to the stage 0 compiler artifacts. Also today, library developers can do ./x.py test --stage 0 library/.. so they can already avoid building the compiler.

onur-ozkan commented 1 month ago

Yeah I forgot mentioning https://github.com/rust-lang/rust/pull/119899.