Open Alphare opened 2 days ago
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jhpratt (or someone else) some time within the next two weeks.
Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review
and S-waiting-on-author
) stays updated, invoking these commands when appropriate:
@rustbot author
: the review is finished, PR author should check the comments and take action accordingly@rustbot review
: the author is ready for a review, this PR will be queued again in the reviewer's queueThe job x86_64-gnu-llvm-18
failed! Check out the build log: (web) (plain)
Trait implementations require a stability attribute, which is why CI is failing. Unfortunately, they also cannot be unstable. For that reason, I'll have the team take a look at it as it will require FCP.
@rustbot label +I-libs-api-nominated
This is my first contribution because I basically stumbled upon this not being implemented and figured it would be a quick fix, sorry if I'm missing anything. I see that all other impls in this file have feature annotations, I'm not sure if this would need one.