search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.77k stars 12.76k forks source link

ci: enble LLVM download for windows-gnu hosts #133266

Open mati865 opened 1 day ago

mati865 commented 1 day ago

Continuation of https://github.com/rust-lang/rust/pull/132781

try-job: dist-i686-mingw try-job: dist-x86_64-mingw

rustbot commented 1 day ago

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

mati865 commented 1 day ago

Basically my plan is to do try build with dist so the artifacts get uploaded and then do another try but with test jobs. If that fails, I think we should merge dist builders change only and then in later PR do the same for test jobs.

Kobzol commented 1 day ago

I would personally prefer to disable LLVM download on the dist runners, to exercise the LLVM build path regularly.

mati865 commented 1 day ago

I think dist runners always build LLVM artifacts for download (at least that appears to be the case in #132781) despite using the same environment variable. Even if that's not the case, changing it would be a bigger change that affects all platforms.

Kobzol commented 1 day ago

Yeah, just to clarify, what I meant was that we shouldn't change the behavior on dist runners - they should always build.