search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.76k stars 12.76k forks source link

Get rid of HIR const checker #133321

Open compiler-errors opened 13 hours ago

compiler-errors commented 13 hours ago

As far as I can tell, the HIR const checker was implemented in https://github.com/rust-lang/rust/pull/66170 because we were not able to issue useful const error messages in the MIR const checker.

This seems to have changed in the last 5 years, probably due to work like #90532. I've tweaked the diagnostics slightly and think the error messages have gotten better in fact.

Thus I think the HIR const checker has reached the end of its usefulness, and we can retire it.

cc @RalfJung

rustbot commented 13 hours ago

r? @wesleywiser

rustbot has assigned @wesleywiser. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot commented 13 hours ago

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

RalfJung commented 8 hours ago

I didn't even know we had another const checker... Cc @rust-lang/wg-const-eval