search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.88k stars 12.78k forks source link

miri: implement `TlsFree` #133457

Open joboet opened 20 hours ago

joboet commented 20 hours ago

If the variable does not need a destructor, std uses racy initialization for creating TLS keys on Windows. With just the right timing, this can lead to TlsFree being called. Unfortunately, with #132654 this is hit quite often, so miri should definitely support TlsFree (documentation).

I'm filing this here instead of in the miri repo so that #132654 isn't blocked for so long.

rustbot commented 20 hours ago

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot commented 20 hours ago

The Miri subtree was changed

cc @rust-lang/miri

saethlin commented 18 hours ago

Looks good to me.

r? saethlin @bors r+

bors commented 18 hours ago

:pushpin: Commit 77fccf59e3838473e234bdb970e7100ba5c361f8 has been approved by saethlin

It is now in the queue for this repository.