rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.88k stars 12.78k forks source link

Add COPYRIGHT-*.html files to distribution and update `COPYRIGHT` #133461

Open jonathanpallant opened 19 hours ago

jonathanpallant commented 19 hours ago

Requires https://github.com/rust-lang/rust/pull/133453 to be merged first.

rustbot commented 19 hours ago

r? @albertlarsan68

rustbot has assigned @albertlarsan68. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rust-log-analyzer commented 19 hours ago

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) ```plain #16 2.931 Building wheels for collected packages: reuse #16 2.932 Building wheel for reuse (pyproject.toml): started #16 3.180 Building wheel for reuse (pyproject.toml): finished with status 'done' #16 3.181 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6 #16 3.181 Stored in directory: /tmp/pip-ephem-wheel-cache-1o4te3p9/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532 #16 3.184 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs #16 3.593 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0 #16 3.593 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv #16 DONE 3.7s --- Checking xz2 v0.1.7 error: this expression creates a reference which is immediately dereferenced by the compiler --> src/core/build_steps/dist.rs:517:33 | 517 | builder.install(&path, &image.join("share/doc/rust/licences"), 0o644); | ^^^^^ help: change this to: `path` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]` error: unnecessary `if let` since only the `Ok` variant of the iterator element is used | | 519 | / for entry in t!(std::fs::read_dir(builder.src.join("LICENSES"))) { 520 | | if let Ok(entry) = entry { 521 | | license(&entry.path()); 523 | | } | |_____________^ | help: remove the `if let` statement in the for loop and then... --- = help: to override `-D warnings` add `#[allow(clippy::manual_flatten)]` help: try --> src/utils/helpers.rs:35:9 | 35 ~ (match $e { 36 + Ok(e) => e, 37 + Err(e) => panic!("{} failed with {}", stringify!($e), e), 38 + }).flatten() error: could not compile `bootstrap` (lib) due to 2 previous errors Build completed unsuccessfully in 0:01:34 local time: Mon Nov 25 16:30:09 UTC 2024 ```
Kobzol commented 2 hours ago

r? @kobzol

(although as JP mentioned, this will need some opinions from the council, probably)