search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.88k stars 12.78k forks source link

Disable `avr-rjmp-offset` on Windows for now #133481

Open jieyouxu opened 11 hours ago

jieyouxu commented 11 hours ago

The linker has been randomly crashing on x86_64-mingw that's causing spurious failures (#133480). Disable this test on Windows for now.

cc @jfrimmel (nothing actionable, just FYI because linker gonna linker) cc @ehuss (who noticed this)

r? compiler (or anyone really)

saethlin commented 11 hours ago

Interesting r? saethlin @bors r+ rollup

bors commented 11 hours ago

:pushpin: Commit 3a42fd2bdcdda6e37a997caf30bae673fa9ca155 has been approved by saethlin

It is now in the queue for this repository.

ChrisDenton commented 6 hours ago

Why not ignore-windows-gnu?

jieyouxu commented 1 hour ago

Why not ignore-windows-gnu?

I didn't bother investigating if it's windows-gnu specifically or also msvc, disabling it on both to be safe for now. Feel free to re-adjust the ignore.

ChrisDenton commented 1 hour ago

windows-gnu and windows-msvc are quite different compiler hosts. It's by no means impossible that they'd be affected by the same issue but I would push back on the default assumption being that they are. We shouldn't reduce test coverage without a good reason, imho.

I'll open a PR once this merges.