search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.91k stars 12.78k forks source link

track whether a non-coherence `TypingMode` has been used to reuse cache entries #133497

Open lcnr opened 18 hours ago

lcnr commented 18 hours ago

see the WIP branch https://github.com/lcnr/rust/tree/typing-mode-is-coherence.

It is now fairly straightforward to track whether evaluation relied on the exact typing mode. finishing this work should result in a reasonable perf improvement

lcnr commented 18 hours ago

See the perf results in https://github.com/rust-lang/rust/pull/133242#issuecomment-2488831602 which accidentally stopped tracking the TypingMode entirely for a rough estimate of the potential impact