search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
96.91k stars 12.52k forks source link

antlr is losing information #15677

Closed emberian closed 7 years ago

emberian commented 10 years ago

See http://stackoverflow.com/questions/24747360/distinguishing-literal-n-vs-embedded-newline. Until there is a resolution to this, the lexer verification is ignoring the contents every token that carries data :(

steveklabnik commented 9 years ago

traige: no changes that i'm aware of

nagisa commented 8 years ago

While we still have ANTLR grammar in tree, it is outdated and we predominantly rely on the other one we have in tree. Perhaps we should just remove ANTLR one now?

emberian commented 8 years ago

The ANTLR grammar was originally intended to be "pure" in the sense that it uses only language description and no code in its operation, and could easily be lifted into some formalism. This is quite at odds with how the flex and bison files operate.

steveklabnik commented 8 years ago

I would be okay removing ANTLR.

On Mar 17, 2016, 05:47 -0400, cmrnotifications@github.com, wrote:

The ANTLR grammar was originally intended to be "pure" in the sense that it uses only language description and no code in its operation, and could easily be lifted into some formalism. This is quite at odds with how the flex and bison files operate.

— You are receiving this because you commented. Reply to this email directly orview it on GitHub(https://github.com/rust-lang/rust/issues/15677#issuecomment-197792228)

Mark-Simulacrum commented 7 years ago

ANTLR grammar is still in-tree. There is now an answer to the SO question, though, so perhaps that's significant to this discussion? It's possible the easiest answer here is to simply remove the ANTLR grammar from in-tree, possibly moving it elsewhere.

steveklabnik commented 7 years ago

Agreed; I'd be happy to just remove it. We're not planning on doing anything with ANTLR in the future that I know of, and if we need it, we can pull it back out of the history.