search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
99.09k stars 12.79k forks source link

Errant edge to krate node #36168

Closed nikomatsakis closed 8 years ago

nikomatsakis commented 8 years ago

I noticed when checking the syntex-syntax node that, when I add a private fn into the crate module, it invalidates the krate-0 module. This is because the metadata includes edges to the immediate children. This seems bad, but then there is also a read whenever we read an inlined item from crate X of the crate root, which means that this winds up triggering bad reuse. I am trying to figure out why this read arises and remove it, but I'd also like to remove the dependency of metadata.

michaelwoerister commented 8 years ago

Was this fixed by https://github.com/rust-lang/rust/commit/c6363b801316c1d8279f55a6be44746d71018ceb?

nikomatsakis commented 8 years ago

@michaelwoerister quite likely; I guess I will make a perf test to check

nikomatsakis commented 8 years ago

Looks good. Posted a PR with a test.