search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
97.97k stars 12.68k forks source link

Reachable symbols should be determined by the MIR #36594

Closed Aatch closed 2 years ago

Aatch commented 8 years ago

Currently, the set of reachable symbols is determined by the privacy, and whether or a function that references the symbol could be inlined cross-crate. With MIR inlining (see #36593), symbols that were previously considered unreachable from outside the crate may become reachable if an item that isn't inlined cross-crate is inlined into another function that is inlined cross-crate.

jonas-schievink commented 8 years ago

This looks like it would fix #35870, too

EDIT: Not inherently, at least

steveklabnik commented 4 years ago

Triage: no idea what the situation is with this bug, honestly.

eddyb commented 4 years ago

cc @michaelwoerister @Zoxc @oli-obk

oli-obk commented 4 years ago

cc @wesleywiser

bjorn3 commented 2 years ago

cc @cjgillot Do you think https://github.com/rust-lang/rust/pull/91743 could make whatever this issue is about visible on stable? Or do you think this issue has been fixed since?

cjgillot commented 2 years ago

I have no idea what this bug is about.

oli-obk commented 2 years ago

the monomorphization collector works completely on MIR nowadays. I think we fixed all these issues since they were occurring with return-position-impl-trait already.